fix: warn when WDK env vars are non-UTF8#596
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds proper warning messages when WDK environment variables contain non-UTF8 characters, addressing issue #580. Previously, such errors were only logged at trace level without distinguishing between missing variables and encoding issues.
Key Changes:
- Added warning-level logging for non-UTF8 environment variables in
get_path_from_env - Distinguished between
NotPresentandNotUnicodeerror variants with appropriate log levels
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
==========================================
- Coverage 82.67% 82.66% -0.01%
==========================================
Files 25 25
Lines 7135 7137 +2
Branches 7135 7137 +2
==========================================
+ Hits 5899 5900 +1
- Misses 1107 1108 +1
Partials 129 129 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gurry
force-pushed
the
580-warn-on-invalid-var
branch
from
ccc7a98 to
75601a1
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4 participants
Fixes #580